Two amendments for the shape analysis#18271
Closed
t-vi wants to merge 2 commits into
Closed
Conversation
apaszke
approved these changes
Mar 21, 2019
| if (type->scalarType() == at::kHalf) { | ||
| type = type->toScalarType(at::kFloat); | ||
| } | ||
| type = type->withDim(1); |
Contributor
There was a problem hiding this comment.
nit: the indentation is messed up here
Collaborator
Author
There was a problem hiding this comment.
👍 Thanks for catching.
Collaborator
Author
|
@pytorchbot merge this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Two small refinements to the shape analysis: - `detach` can set requires grad to false for dimensioned tensors (not sure if I would also need to deal with Complete?). - add `batch_norm_stats`. I noticed these while looking at what's going on when trying to code batch norm manually. (Hi wanchaol ) Pull Request resolved: pytorch#18271 Differential Revision: D14561303 Pulled By: ezyang fbshipit-source-id: 64a6879392e77403c44f2ed82f84b6397754d0ea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small refinements to the shape analysis:
detachcan set requires grad to false for dimensioned tensors (not sure if I would also need to deal with Complete?).batch_norm_stats.I noticed these while looking at what's going on when trying to code batch norm manually. (Hi @wanchaol )