[JIT] Handle None indexing in TorchScript#18615
Closed
t-vi wants to merge 1 commit into
Closed
Conversation
t[None], t[None, 1:, None] and friends for unsqueezing Fixes: pytorch#12810
Collaborator
Author
|
I'd say the CI isn't me. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
It would be nice to handle lists as well, since None indexing is also valid for lists in python |
Contributor
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: t[None], t[None, 1:, None] and friends for unsqueezing Fixes: pytorch#12810 Pull Request resolved: pytorch#18615 Differential Revision: D14837039 Pulled By: wanchaol fbshipit-source-id: ab3862c41629f087b0a46b7c59c93dac4018e6fe
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: t[None], t[None, 1:, None] and friends for unsqueezing Fixes: pytorch#12810 Pull Request resolved: pytorch#18615 Differential Revision: D14837039 Pulled By: wanchaol fbshipit-source-id: ab3862c41629f087b0a46b7c59c93dac4018e6fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t[None], t[None, 1:, None] and friends for unsqueezing
Fixes: #12810