Add python only default init expression; Implement stft, hann/hamming/bartlett window.#4095
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
416043f to
9af456f
Compare
|
See above for what this PR contains. |
050e9a7 to
ad46de8
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@pytorchbot retest this please |
1 similar comment
|
@pytorchbot retest this please |
03be651 to
2f42b55
Compare
|
@ssnl once you resolve merge conflict, this is good to go. |
…ython only default initialization
|
@soumith merged & tested :) thanks! |
|
@ssnl I think it would be nice to also have an inverse stft |
|
@faroit Yes, it's on my list of things to do. Thanks for bringing it up. |
|
@ssnl if you need help e.g. testing perfect reconstruction etc. just ping me |
|
@faroit thanks! |
…/bartlett window. (pytorch#4095) * implement stft * addressed comments; implemented window functions; added support for python only default initialization
This PR
atan2for cuda double & half tensors. Refactoredatan2toTHCNumerics, Op toTHCTensorMathPointwise.cuh.Scalar pinnorm) or have a type that doesn't allow default valueNone/NULL/nullptr(e.g.,int64_t fft_sizeinstft).a. Changes
normto also use this in bothDeclarations.cwrapfor torch.norm named arguments do not work as expected #1419 . WhenTensorandVariablemerge, it should fix the issues in torch.norm named arguments do not work as expected #1419 .On 3: Now in
python_variable_methods.cpp, if an argument has python only default value, it will be generated like the following. I added the comment for clarification purpose. It won't be in actual code.