Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding torch.expm1() and its inplace function#4350

Merged
soumith merged 4 commits into
pytorch:masterfrom
vishwakftw:expm1
Dec 28, 2017
Merged

Adding torch.expm1() and its inplace function#4350
soumith merged 4 commits into
pytorch:masterfrom
vishwakftw:expm1

Conversation

@vishwakftw
Copy link
Copy Markdown
Contributor

@vishwakftw vishwakftw commented Dec 26, 2017

This closes issue #4007 . Please let me know your views. I followed a similar style as done for the implementation of torch.log1p.

@pytorchbot
Copy link
Copy Markdown
Collaborator

pytorchbot commented Dec 26, 2017

@vishwakftw, thanks for your PR! We identified @zdevito to be a potential reviewer.

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Dec 27, 2017

@pytorchbot add to whitelist

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Dec 27, 2017

looks good to me, just want to run it by @gchanan for ATen interface style

@vishwakftw
Copy link
Copy Markdown
Contributor Author

vishwakftw commented Dec 27, 2017 •
edited
Loading

I monitored the builds, realized that gradients are incorrect. Sorry about that, I have fixed it now.

@vishwakftw
Copy link
Copy Markdown
Contributor Author

vishwakftw commented Dec 28, 2017

The two failed checks seem to be caused by some remote connection problem.

cc: @soumith

@soumith soumith merged commit e519ef5 into pytorch:master Dec 28, 2017
@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Dec 28, 2017

thanks a lot @vishwakftw !!!

@vishwakftw vishwakftw deleted the expm1 branch December 28, 2017 10:00
apaszke
apaszke reviewed Dec 28, 2017
View reviewed changes
Comment thread tools/autograd/derivatives.yaml
self: grad * result

- name: expm1(Tensor self)
self: grad * self.exp()

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@vishwakftw vishwakftw restored the expm1 branch December 28, 2017 16:02
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@vishwakftw @soumith
Adding torch.expm1() and its inplace function (pytorch#4350)
fe769ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vishwakftw @pytorchbot @soumith @apaszke @ezyang