Check shape instead of number of elements for some losses#5085
Merged
Conversation
soumith
approved these changes
Feb 6, 2018
Collaborator
|
the documentation of MSELoss is clear about this behavior: If the right "fix" is to remove this behavior, the documentation has to be updated. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* Check shape instead of number of elements * Remove arbitrary-shape spec in MSELoss docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5007
Fixes #4938
Removes the check that the input, target have the same number of elements and adds a shape check instead for the following:
At some point it would be nice to move these to ATen and perhaps enable broadcasting on them, but right now this is just a bugfix.
Test Plan
new unit test