Add optimization to norm for common norms#5722
Merged
Merged
Conversation
apaszke
approved these changes
Mar 12, 2018
Contributor
apaszke
left a comment
There was a problem hiding this comment.
Does CUDA have optimized implementations?
Contributor
Author
|
Yup! |
|
wait so is this fixed...? |
Collaborator
|
@JaeDukSeo yes |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5671
The reported issue is that on the CPU path, norm(value, dim) is slower than manually using pow, sqrt, and summing.
It turns out that the CPU path for norm(value, dim) is missing optimizations in the
value=1, 2cases. I added those in as well as an optimization forvalue = 3(not sure if this is necessary, but this optimization is used fortensor.pow(3)).@li-roy could you take a look?
Perf numbers: