Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix mypy.ini#61333

Closed
malfet wants to merge 1 commit into
masterfrom
malfet/fix-mypy.ini
Closed

Fix mypy.ini#61333
malfet wants to merge 1 commit into
masterfrom
malfet/fix-mypy.ini

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Jul 7, 2021 •
edited
Loading

Fixes CI regression caused by #61119
Unlike Python, .ini string lists could not end with trailing comma.

Fixes CI on master

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 9cf978a (more details on the Dr. CI page and at hud.pytorch.org/pr/61333):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Lint / mypy (1/1)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-07-07T05:00:58.1834270Z torch/nn/modules/m...ed type annotation for '_modules' [var-annotated] 
2021-07-07T05:00:28.4111247Z + for CONFIG in mypy*.ini
2021-07-07T05:00:28.4112381Z + mypy --config=mypy.ini
2021-07-07T05:00:58.1818416Z torch/nn/modules/module.py:257:9: error: Need type annotation for '_parameters'  [var-annotated]
2021-07-07T05:00:58.1820432Z torch/nn/modules/module.py:258:9: error: Need type annotation for '_buffers'  [var-annotated]
2021-07-07T05:00:58.1822764Z torch/nn/modules/module.py:259:9: error: Need type annotation for '_non_persistent_buffers_set' (hint: "_non_persistent_buffers_set: Set[<type>] = ...")  [var-annotated]
2021-07-07T05:00:58.1824976Z torch/nn/modules/module.py:260:9: error: Need type annotation for '_backward_hooks'  [var-annotated]
2021-07-07T05:00:58.1826883Z torch/nn/modules/module.py:262:9: error: Need type annotation for '_forward_hooks'  [var-annotated]
2021-07-07T05:00:58.1828828Z torch/nn/modules/module.py:263:9: error: Need type annotation for '_forward_pre_hooks'  [var-annotated]
2021-07-07T05:00:58.1830737Z torch/nn/modules/module.py:264:9: error: Need type annotation for '_state_dict_hooks'  [var-annotated]
2021-07-07T05:00:58.1832692Z torch/nn/modules/module.py:265:9: error: Need type annotation for '_load_state_dict_pre_hooks'  [var-annotated]
2021-07-07T05:00:58.1834270Z torch/nn/modules/module.py:266:9: error: Need type annotation for '_modules'  [var-annotated]
2021-07-07T05:01:39.9014902Z Found 9 errors in 1 file (checked 1385 source files)
2021-07-07T05:01:41.6800719Z + STATUS=fail
2021-07-07T05:01:41.6807217Z + '[' -n fail ']'
2021-07-07T05:01:41.6807968Z + echo 'Please fix the above mypy warnings.'
2021-07-07T05:01:41.6808476Z + false
2021-07-07T05:01:41.6808997Z Please fix the above mypy warnings.
2021-07-07T05:01:41.6814856Z ##[error]Process completed with exit code 1.
2021-07-07T05:01:41.6915511Z Post job cleanup.
2021-07-07T05:01:41.7990971Z [command]/usr/bin/git version
2021-07-07T05:01:41.8077532Z git version 2.32.0

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 7, 2021

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet changed the title Fix mypy.init Fix mypy.ini Jul 7, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 7, 2021

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 7, 2021

@malfet merged this pull request in 9813b9b.

@zhouzhuojie
Copy link
Copy Markdown
Contributor

zhouzhuojie commented Jul 7, 2021

good catch! thanks for the fix

@zhouzhuojie zhouzhuojie mentioned this pull request Jul 7, 2021
Closed
@malfet malfet deleted the malfet/fix-mypy.ini branch December 21, 2021 20:26
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@malfet @facebook-github-bot
Fix mypy.ini (pytorch#61333)
0990b54 
Summary:
Fixes CI regression caused by pytorch#61119
Unlike Python, `.ini` string lists could not  end with trailing comma.

Fixes CI on master

Pull Request resolved: pytorch#61333

Reviewed By: bhosmer

Differential Revision: D29578696

Pulled By: malfet

fbshipit-source-id: b81e5f4c0a553299c4d4bee0a9bb73748910795f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bhosmer bhosmer bhosmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @facebook-github-bot @zhouzhuojie @bhosmer