torch.linalg.qr: forward AD support#67268
Closed
nikitaved wants to merge 9 commits into
Closed
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 09921ea (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Collaborator
Author
|
forward AD tests hang in my environment now, investigating... |
…taved/linalg_qr_forward_AD
lezcano
reviewed
Oct 27, 2021
Comment on lines
+2689
to
+2694
| auto dB1 = std::get<0>(at::triangular_solve( | ||
| dA1.mT().matmul(Q.conj()), | ||
| R1, | ||
| /*upper=*/true, | ||
| /*transpose=*/true | ||
| )).mT(); |
Collaborator
There was a problem hiding this comment.
I'll update these once the new lovely triangular_solve is in :)
Contributor
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…taved/linalg_qr_forward_AD
…taved/linalg_qr_forward_AD
Collaborator
Author
|
@albanD , this PR is now unblocked. It could get merged once CIs show green. |
…taved/linalg_qr_forward_AD
…taved/linalg_qr_forward_AD
…taved/linalg_qr_forward_AD
Contributor
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Collaborator
|
Thanks for the quick rebase! |
Contributor
14 tasks
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: As per title. Pull Request resolved: pytorch#67268 Reviewed By: ngimel Differential Revision: D31960517 Pulled By: albanD fbshipit-source-id: bfd1028a8d352f550efb420f9ca609c09f4a7484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title.