No Default argument to max_unpool functions (Fixes #7327)#7388
Conversation
Contributor
|
Thanks. Can we have a test for this case? |
Author
|
Contributor
|
Hi @vedaanta, your proposed test looks good. Can you add it to |
ezyang
approved these changes
May 14, 2018
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
…orch#7388) * Fix for Issue pytorch#7327 * Added testcase for max_unpool
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…orch#7388) * Fix for Issue pytorch#7327 * Added testcase for max_unpool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions max_unpool1d, max_unpool2d, max_unpool3d break for
stride=None.Fixed so as to default it to kernel_size.