Conversation
samestep
approved these changes
Jun 18, 2021
Contributor
samestep
left a comment
There was a problem hiding this comment.
lgtm but why can't we just add unidiff==0.6.0 to requirements.txt in pytorch/pytorch?
walterddr
approved these changes
Jun 18, 2021
janeyx99
approved these changes
Jun 18, 2021
Contributor
Author
everyone has to install requirements.txt to build PyTorch so we should make it a point to keep it minimal, adding something there needs more consideration. the usage here is pretty specific and ci-only for most people |
driazati
added a commit
to pytorch/pytorch
that referenced
this pull request
Jun 21, 2021
This switches clang-tidy to the fresh tag from https://github.com/pytorch/test-infra/runs/2860763986 which has a fix for the missing OMP headers we were seeing. Along with #60225 this should restore clang-tidy to normal functionality and we shouldn't see any spurious warnings. The diff parsing was also broken on diffs that change an entire file (git uses -1 -> +1 as the line range in those diffs for some reason). Rather than deal with these intricacies myself I copied from https://stackoverflow.com/a/39909397 which uses the `unidiff` library, so we need to add that to the image first: pytorch/test-infra#43 Differential Revision: [D29239783](https://our.internmc.facebook.com/intern/diff/D29239783) [ghstack-poisoned]
jeanschmidt
pushed a commit
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pytorch/pytorch#60297
This one has to land and build on master before that PR can be tested + landed