Add minor comment about ToTensor #8300

NicolasHug · 2024-03-05T13:53:44Z

As discussed offline with @MarcSzafraniec this should help clarify that the output is equivalent although not strictly ==.

cc @vfdev-5

pytorch-bot · 2024-03-05T13:53:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8300

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 18 Unrelated Failures

As of commit f9f7713 with merge base bdd690e ():

NEW FAILURES - The following jobs have failed:

CMake / macos (macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
CMake / macos (macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

CMake / linux (linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Docs / build / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / c-source / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / python-source-and-configs / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / python-types / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.10, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.11, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / onnx / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-extended / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vfdev-5

Stamp

Reviewed By: vmoens Differential Revision: D55062776 fbshipit-source-id: 601c6da2b771b2e39843009f759f38bab6673bdf

Add minor comment about ToTensor

19fd3fd

facebook-github-bot added the cla signed label Mar 5, 2024

NicolasHug added enhancement module: transforms and removed cla signed labels Mar 5, 2024

facebook-github-bot added the cla signed label Mar 5, 2024

vfdev-5 approved these changes Mar 13, 2024

View reviewed changes

Merge branch 'main' into aefjnalefjnalejnf

f9f7713

NicolasHug merged commit dd66a9d into pytorch:main Mar 13, 2024

NicolasHug deleted the aefjnalefjnalejnf branch March 13, 2024 10:31

NicolasHug added module: documentation and removed module: transforms labels Mar 13, 2024

facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024

[fbsync] Add minor comment about ToTensor (#8300)

e3255f4

Reviewed By: vmoens Differential Revision: D55062776 fbshipit-source-id: 601c6da2b771b2e39843009f759f38bab6673bdf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add minor comment about ToTensor #8300

Add minor comment about ToTensor #8300

Uh oh!

NicolasHug commented Mar 5, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Mar 5, 2024 •

edited

Loading

Uh oh!

vfdev-5 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add minor comment about ToTensor #8300

Add minor comment about ToTensor #8300

Uh oh!

Conversation

NicolasHug commented Mar 5, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8300

❌ 14 New Failures, 18 Unrelated Failures

Uh oh!

vfdev-5 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NicolasHug commented Mar 5, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 5, 2024 •

edited

Loading