Add allow_empty parameter to ImageFolder and related utils #8311

NicolasHug · 2024-03-13T12:38:19Z

Closes #8297

pytorch-bot · 2024-03-13T12:38:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8311

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 16 Unrelated Failures

As of commit b733bcd with merge base e00f4e6 ():

NEW FAILURES - The following jobs have failed:

CMake / macos (macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
CMake / macos (macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

CMake / linux (linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Docs / build / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / c-source / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / python-source-and-configs / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / python-types / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / onnx / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-extended / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

test/test_datasets.py

pmeier

LGTM with one minor comment regarding using the dataset test framework.

test/test_datasets.py

NicolasHug · 2024-03-13T13:29:38Z

linux tests are passing so I'll risk a merge (macos failure is unrelated). Thanks a lot for the review!

…8311) Reviewed By: vmoens Differential Revision: D55062799 fbshipit-source-id: 0250b54ae613531f8309750ccd42028d4a4288f0

Add allow_empty parameter to ImageFolder and related utils

89c840f

NicolasHug added enhancement module: datasets labels Mar 13, 2024

NicolasHug requested a review from pmeier March 13, 2024 12:38

facebook-github-bot added the cla signed label Mar 13, 2024

NicolasHug commented Mar 13, 2024

View reviewed changes

test/test_datasets.py Show resolved Hide resolved

pmeier approved these changes Mar 13, 2024

View reviewed changes

test/test_datasets.py Show resolved Hide resolved

Merge branch 'main' into allow_empty

b733bcd

NicolasHug merged commit 9563e3e into pytorch:main Mar 13, 2024

NicolasHug deleted the allow_empty branch March 13, 2024 13:29

facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024

[fbsync] Add allow_empty parameter to ImageFolder and related utils (#…

a987ac8

…8311) Reviewed By: vmoens Differential Revision: D55062799 fbshipit-source-id: 0250b54ae613531f8309750ccd42028d4a4288f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add allow_empty parameter to ImageFolder and related utils #8311

Add allow_empty parameter to ImageFolder and related utils #8311

Uh oh!

NicolasHug commented Mar 13, 2024

Uh oh!

pytorch-bot bot commented Mar 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

pmeier left a comment

Uh oh!

Uh oh!

NicolasHug commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add allow_empty parameter to ImageFolder and related utils #8311

Add allow_empty parameter to ImageFolder and related utils #8311

Uh oh!

Conversation

NicolasHug commented Mar 13, 2024

Uh oh!

pytorch-bot bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8311

❌ 12 New Failures, 16 Unrelated Failures

Uh oh!

Uh oh!

pmeier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NicolasHug commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot bot commented Mar 13, 2024 •

edited

Loading