Add pathlib.Path support for image IO utils #8314

NicolasHug · 2024-03-13T15:24:54Z

Towards #8120
Needs #8313 to be merged first

pytorch-bot · 2024-03-13T15:24:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8314

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 2 Pending, 18 Unrelated Failures

As of commit de684f0 with merge base 2bababf ():

NEW FAILURES - The following jobs have failed:

CMake / macos (macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
CMake / macos (macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.12, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Docs / build / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / c-source / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / python-source-and-configs / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Lint / python-types / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.10, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.11, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.12, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / onnx / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-extended / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug · 2024-03-15T14:18:24Z

torchvision/io/image.py


    Args:
-        path (str): the path to the file to be read
+        path (str or ``pathlib.Path``): the path to the file to be read


Note that we can't change the type signatures because of torchscript.

Reviewed By: vmoens Differential Revision: D55062764 fbshipit-source-id: d0a7c100088ce6990a557c857edfda9f8c9284ff

NicolasHug added 2 commits March 13, 2024 15:00

Add torchscript test for io image stuff

536b06a

Add pathlib.Path support for io image

3165e9b

facebook-github-bot added the cla signed label Mar 13, 2024

NicolasHug added enhancement module: io and removed cla signed labels Mar 13, 2024

NicolasHug changed the title ~~Add torchscript test for io image stuff~~ Add pathlib.Path support for image IO utils Mar 13, 2024

facebook-github-bot added the cla signed label Mar 13, 2024

Merge branch 'main' into pathlibio_but_for_real

34ba35f

NicolasHug requested review from pmeier and vfdev-5 March 13, 2024 16:24

Merge branch 'main' into pathlibio_but_for_real

9e1fa6f

NicolasHug commented Mar 15, 2024

View reviewed changes

NicolasHug mentioned this pull request Mar 15, 2024

Document that datasets support pathlib.Path #8321

Merged

vfdev-5 approved these changes Mar 17, 2024

View reviewed changes

Merge branch 'main' into pathlibio_but_for_real

de684f0

NicolasHug merged commit 4028d9f into pytorch:main Mar 17, 2024

NicolasHug mentioned this pull request Mar 18, 2024

Pathlib support #8120

Closed

facebook-github-bot pushed a commit that referenced this pull request Mar 21, 2024

[fbsync] Add pathlib.Path support for image IO utils (#8314)

835b8e0

Reviewed By: vmoens Differential Revision: D55062764 fbshipit-source-id: d0a7c100088ce6990a557c857edfda9f8c9284ff

NicolasHug mentioned this pull request May 31, 2024

Add pathlib.Path support to read_image #2962

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add pathlib.Path support for image IO utils #8314

Add pathlib.Path support for image IO utils #8314

Uh oh!

NicolasHug commented Mar 13, 2024

Uh oh!

pytorch-bot bot commented Mar 13, 2024 •

edited

Loading

Uh oh!

NicolasHug Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add pathlib.Path support for image IO utils #8314

Add pathlib.Path support for image IO utils #8314

Uh oh!

Conversation

NicolasHug commented Mar 13, 2024

Uh oh!

pytorch-bot bot commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8314

❌ 16 New Failures, 2 Pending, 18 Unrelated Failures

Uh oh!

NicolasHug Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot bot commented Mar 13, 2024 •

edited

Loading