Put back StanfordCars.download (the function, NOT the feature) #8324

NicolasHug · 2024-03-15T16:24:22Z

The download() method was removed in #8309 but since it's public it's best to keep it and raise the error there. Addresses #8309 (comment) which I missed - sorry

test:

[ins] In [1]: from torchvision.datasets import StanfordCars
[ins] In [2]: StanfordCars(root="/tmp", download=True)
         ...: 
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-2-a557e888a29e> in <module>
----> 1 StanfordCars(root="/tmp", download=True)

~/dev/vision/torchvision/datasets/stanford_cars.py in __init__(self, root, split, transform, target_transform, download)
     62 
     63         if download:
---> 64             self.download()
     65 
     66         if not self._check_exists():

~/dev/vision/torchvision/datasets/stanford_cars.py in download(self)
    102 
    103     def download(self):
--> 104         raise ValueError(
    105             "The original URL is broken so the StanfordCars dataset is not available for automatic "
    106             "download anymore. You can try to download it manually following "

ValueError: The original URL is broken so the StanfordCars dataset is not available for automatic download anymore. You can try to download it manually following https://github.com/pytorch/vision/issues/7545#issuecomment-1631441616, and set download=False to avoid this error.

pytorch-bot · 2024-03-15T16:24:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8324

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 1 Pending, 23 Unrelated Failures

As of commit 8acff3b with merge base 4028d9f ():

NEW FAILURES - The following jobs have failed:

CMake / macos (macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.12, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / macos (macos-m1-stable) / macos-job (gh)
CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
Docs / build / linux-job (gh)
Lint / python-source-and-configs / linux-job (gh)
Lint / python-types / linux-job (gh)
Prototype tests on Linux / unittests-prototype (3.10, linux.12xlarge, cpu) / linux-job (gh)
Prototype tests on Linux / unittests-prototype (3.11, linux.12xlarge, cpu) / linux-job (gh)
Prototype tests on Linux / unittests-prototype (3.12, linux.12xlarge, cpu) / linux-job (gh)
Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh)
Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh)
Tests / onnx / linux-job (gh)
Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh)
Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh)
Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2024-03-17T23:05:28Z

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

…e) (#8324) Reviewed By: vmoens Differential Revision: D55062768 fbshipit-source-id: b9a89b007572b8ba85b5eedefaff41275d535517

Put back StanfordCars.download (the function, NOT the feature)

7d8e779

NicolasHug requested review from pmeier and vfdev-5 March 15, 2024 16:24

facebook-github-bot added the cla signed label Mar 15, 2024

vfdev-5 approved these changes Mar 17, 2024

View reviewed changes

Merge branch 'main' into laefjnlaefnlajenf

8acff3b

NicolasHug merged commit ed4710b into pytorch:main Mar 17, 2024

NicolasHug deleted the laefjnlaefnlajenf branch March 17, 2024 22:48

NicolasHug added the other if you have no clue or if you will manually handle the PR in the release notes label Mar 17, 2024

facebook-github-bot pushed a commit that referenced this pull request Mar 21, 2024

[fbsync] Put back StanfordCars.download (the function, NOT the featur…

ed23929

…e) (#8324) Reviewed By: vmoens Differential Revision: D55062768 fbshipit-source-id: b9a89b007572b8ba85b5eedefaff41275d535517

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Put back StanfordCars.download (the function, NOT the feature) #8324

Put back StanfordCars.download (the function, NOT the feature) #8324

Uh oh!

NicolasHug commented Mar 15, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Put back StanfordCars.download (the function, NOT the feature) #8324

Put back StanfordCars.download (the function, NOT the feature) #8324

Uh oh!

Conversation

NicolasHug commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8324

❌ 12 New Failures, 1 Pending, 23 Unrelated Failures

Uh oh!

github-actions bot commented Mar 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NicolasHug commented Mar 15, 2024 •

edited

Loading

pytorch-bot bot commented Mar 15, 2024 •

edited

Loading