Ignore some mypy errors #8404

NicolasHug · 2024-05-03T10:31:51Z

This silences these 2 mypy errors:

  torchvision/prototype/utils/_internal.py:102: error: Argument 1 to "memoryview"
  has incompatible type "ndarray[Any, Any]"; expected "Buffer"  [arg-type]
              self._memory = memoryview(tensor.numpy())
                                        ^~~~~~~~~~~~~~
  torchvision/datasets/cityscapes.py:191: error: Incompatible types in assignment
  (expression has type "Image", variable has type "Dict[str, Any]")  [assignment]
                      target = Image.open(self.targets[index][i])
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

pytorch-bot · 2024-05-03T10:31:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8404

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 18 New Failures, 19 Unrelated Failures

As of commit 7aa8d93 with merge base 8134306 ():

NEW FAILURES - The following jobs have failed:

Build Linux Conda / pytorch/vision / upload / conda-py3_8-cuda12_4 (gh)
Unable to find an artifact with the name: pytorch_vision__3.8_cu124_
CMake / macos (macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
CMake / macos (macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Lint / python-types / linux-job (gh)
Tests / unittests-macos (3.10, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.11, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.12, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-macos (3.9, macos-12) / macos-job (gh)
The process '/usr/local/bin/git' failed with exit code 128
Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

CMake / linux (linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
CMake / linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Docs / build / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Lint / c-source / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Lint / python-source-and-configs / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.10, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.11, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.12, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Prototype tests on Linux / unittests-prototype (3.9, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / onnx / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-extended / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.11, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pmeier · 2024-05-03T11:25:27Z

torchvision/datasets/cityscapes.py

                target = self._load_json(self.targets[index][i])
            else:
-                target = Image.open(self.targets[index][i])
+                target = Image.open(self.targets[index][i])  # type: ignore[assignment]


Nit: You can get rid of this by putting target: Any above the if

github-actions · 2024-05-03T11:45:04Z

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

Reviewed By: vmoens Differential Revision: D57099462 fbshipit-source-id: 297d501192d47caa4d3be158f054c43273b2ecba

Ignore some mypy errors

9cbfa3d

NicolasHug requested a review from pmeier May 3, 2024 10:31

facebook-github-bot added the cla signed label May 3, 2024

NicolasHug added code quality and removed cla signed labels May 3, 2024

facebook-github-bot added the cla signed label May 3, 2024

pmeier reviewed May 3, 2024

View reviewed changes

pmeier approved these changes May 3, 2024

View reviewed changes

Merge branch 'main' into aljenfljanefaef

7aa8d93

NicolasHug merged commit f766d7a into pytorch:main May 3, 2024

NicolasHug deleted the aljenfljanefaef branch May 3, 2024 11:44

facebook-github-bot pushed a commit that referenced this pull request May 8, 2024

[fbsync] Ignore some mypy errors (#8404)

277e233

Reviewed By: vmoens Differential Revision: D57099462 fbshipit-source-id: 297d501192d47caa4d3be158f054c43273b2ecba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ignore some mypy errors #8404

Ignore some mypy errors #8404

Uh oh!

NicolasHug commented May 3, 2024

Uh oh!

pytorch-bot bot commented May 3, 2024 •

edited

Loading

Uh oh!

pmeier May 3, 2024

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ignore some mypy errors #8404

Ignore some mypy errors #8404

Uh oh!

Conversation

NicolasHug commented May 3, 2024

Uh oh!

pytorch-bot bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8404

❌ 18 New Failures, 19 Unrelated Failures

Uh oh!

pmeier May 3, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot bot commented May 3, 2024 •

edited

Loading