Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3965
For some reason, on Windows we need to define the
PyInit_video_reader
PyInit_image
andPyInit__C
symbols, otherwise the windows linker fails with something likeTo avoid that we were defining the symbols as
But that
PyMODINIT_FUNC
forced us to includePython.h
and take a dependency on Libpython. (BTW, we probably never needed to link to libpython like we did in the CMakeFile.txt, we probably only needed the headers, but that's another story.)This PR changes this
PyMODINIT_FUNC
into avoid*
, which seems to work. In reality,PyMODINIT_FUNC
isPyObject_t*
.