Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add roi_align nondeterministic support for XPU #8931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

Add roi_align nondeterministic support for XPU #8931

merged 3 commits into from
Feb 25, 2025

Conversation

frost-intel
Copy link
Contributor

Fixes part of intel/torch-xpu-ops#1264, along with pytorch/pytorch#147541, to allow XPU device to use the non-deterministic compiled _roi_align op.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8931

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 4 Pending, 1 Unrelated Failure

As of commit 79da54b with merge base d462da2 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @frost-intel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

NicolasHug
NicolasHug approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frost-intel

@NicolasHug NicolasHug merged commit d28001e into pytorch:main Feb 25, 2025
64 of 69 checks passed
facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2025
@NicolasHug @facebook-github-bot
[fbsync] Add roi_align nondeterministic support for XPU (#8931)
155b4ea 
Summary: Co-authored-by: frost-intel <frost.mitchell@intelcom>

Reviewed By: scotts

Differential Revision: D77997052

fbshipit-source-id: 40237bcbf1e8e42ca800538490b1dd237ffd67d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed enhancement module: ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frost-intel @facebook-github-bot @NicolasHug