Updating decode_gif to default to DISPOSE_DO_NOT to fix animated gif loading #9241
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are errors loading animated gifs where the frame disposal method is set to DISPOSAL_UNSPECIFIED #9009
This is because when an animated gif has disposal mode
DISPOSAL_UNSPECIFIED
,decode_gif
is defaulting to "background" drawing mode. It needs to beDISPOSE_DO_NOT
instead where changes are overwritten onto the previous canvas. This is the default behaviour of web browsers and libraries like Pillow - GifImagePlugin.py.After this the example gif subsequent frames display correctly