Stop requiring a bleeding-edge Cython.#206
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 49.24% 49.24%
=======================================
Files 4 4
Lines 266 266
Branches 39 39
=======================================
Hits 131 131
Misses 121 121
Partials 14 14
Continue to review full report at Codecov.
|
|
Based on the fact that 3.0.0b1's compiler directive would require us to detect the cython version at buildtime, which is annoying, I can back this PR as a temporary fix until 3.0.0 stabilizes. |
3d15b7f to
ee97224
Compare
|
For any future visitors to this PR, most of the discussion was on #205. |
|
Yikes, it looks like you have some auto-formatting enabled. That makes the diff a lot more complex than it needs to be. Is there any way to revert that? I absolutely open to formatting PRs, but it would be good if it was separated into a different PR. I also I have strong opinions on quotes. Particularly I believe: I also do have an auto-formatter that accomplishes this. I'm fine with the changes to the docstring spacing, import sorting, and getting rid of parens around the yeild, but the extra new lines in the argument parser and other function calls and switching to double quotes is something I'd rather not have. |
Yikes indeed! Sorry, that was absolutely unintentional -- I have a hook to apply black, which fired. I've repushed with those formatting changes dropped. |
ee97224 to
d424aae
Compare
Requiring `Cython>=3.0.0a11` opens the door to any later pre-release; this includes the newly-released 3.0.0b1, which breaks backwards compatibility or requires the addition of a non-backwards-compatible compiler flag (`legacy_implicit_noexcept`). Fixing this would require code changes and pinning the minimum Cython version to 3.0.0b1. There is no reason to require a bleeding-edge version of Cython. Doing so opens the door to installs suddenly failing due to breaking changes in dependencies, such as this one. Python 3.12 will break compatibility with Cython 0.29, however, so we make an exception for that version of Python. For Python 3.12, we leave Cython pinned to 3.0.0a11, which is the latest version which works with that Python but is still compatible with the current code. For other versions of Python, revert the version bump to bleeding-edge Cython added in a9448ec, and only require 0.29.24 or higher. Fixes: pyutils#204.
d424aae to
152c0d4
Compare
Fixes: #204. See #205 for an alternate fix, which I don't prefer.