Codecov Report

❌ Patch coverage is 92.27642% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.56%. Comparing base (a15cc1a) to head (d95c0f5).

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   98.02%   96.56%   -1.47%     
==========================================
  Files           4        4              
  Lines         659      844     +185     
  Branches       82      104      +22     
==========================================
+ Hits          646      815     +169     
- Misses          7       20      +13     
- Partials        6        9       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was tested upstream with pyvista/pyvista#7878
It works, but it took approx 40 mins (without using parallel testing) to convert the 1540 vtksz files to screenshots using playwright:
https://github.com/pyvista/pyvista/actions/runs/17771842735/job/50509762607?pr=7878#step:13:51836

Wondering if maybe @akaszynski can comment on this? I think it's useful to test the interactive images (there are many open issues about interactive plots not working), but perhaps it's not worth it if it adds so much overhead?

Instead of generating vtksz screenshots here with pytest-pyvista, we could alternatively enable this as an option as part of the pyvista-plot directive directly. That way, the images would already be in the build directory. It would still require similar processing times to convert vtksz files to screenshots, though we can perhaps we can use Plotter.export_html directly instead of converting the vtksz files to html.

This was tested upstream with pyvista/pyvista#7878
It works, but it took approx 40 mins (without using parallel testing) to convert the 1540 vtksz files to screenshots using playwright:

Considering we've had a few bad interactive images, I see no issue with including this in our testing. Ideally we could get the time down to ~20 minutes using parallel testing. pyvista-plot directive should just render static images using RenderWindow, and I'm prefer to keep separation of concerns.

We have enough servers to support this testing, and I have two spares should this end up bogging down our CI.

This was tested upstream with pyvista/pyvista#7878
It works, but it took approx 40 mins (without using parallel testing) to convert the 1540 vtksz files to screenshots using playwright:

Considering we've had a few bad interactive images, I see no issue with including this in our testing. Ideally we could get the time down to ~20 minutes using parallel testing. pyvista-plot directive should just render static images using RenderWindow, and I'm prefer to keep separation of concerns.

We have enough servers to support this testing, and I have two spares should this end up bogging down our CI.

Thanks for the feedback. Let's keep this feature as part of pytest-pyvista then. I'll see if I can reduce the test times. If you happen to be familiar with taking screenshots of html files and can think of some other way to speed this up let me know...

This was tested upstream with pyvista/pyvista#7878
It works, but it took approx 40 mins (without using parallel testing) to convert the 1540 vtksz files to screenshots using playwright:

Considering we've had a few bad interactive images, I see no issue with including this in our testing. Ideally we could get the time down to ~20 minutes using parallel testing.

We have enough servers to support this testing, and I have two spares should this end up bogging down our CI.

Reduced to 17 mins by using a single browser context with 584da66, see the run here:

https://github.com/pyvista/pyvista/actions/runs/17775690805/job/50522678419?pr=7878#step:13:51840

And I tried using -n8 for the tests to reduce this further and got worker errors, will need to make these tests thread-safe.

Reduced to 17 mins by using a single browser context with 584da66, see the run here:

17 minutes is more than good! Nice work.

Ready for review