Copy before unstructured grid clean #6337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6337 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 142 142
Lines 26313 26313
=======================================
Hits 25574 25574
Misses 739 739 |
tkoyama010
reviewed
Jul 3, 2024
tkoyama010
approved these changes
Jul 3, 2024
This was referenced Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #6208 by copying the unstructured grid before cleaning it.
Turns out that
vtkStaticCleanUnstructuredGridmodifies the connectivity of the input grid. From their documentation:Therefore, to avoid side-effects, let's always copy the input grid when cleaning.
Performance Considerations
Ideally we'd just shallow copy the input
UnstructuredGridand then deep copy the cells. However, there's an edge case where the input grid has polyhedral cells and we'd have to also code up that edge case. I'm leaning on the side of caution and just copying the entire input grid, especially as the copy operation is unlikely to be the long running operation.