Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add OrthogonalPlanesSource for generating orthogonal planes #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jul 20, 2024
Merged

Add OrthogonalPlanesSource for generating orthogonal planes #6366

merged 37 commits into from
Jul 20, 2024

Conversation

user27182
Copy link
Contributor

@user27182 user27182 commented Jul 11, 2024 •
edited
Loading

Overview

New class for generating orthogonal planes. The output is a MultiBlock with the three planes. The planes can be sized to fit any bounds input. The orientations of the planes are well-defined and the direction of their normals can be controlled.

The planes can be used for downstream computations, e.g. distance from plane queries. They are also useful for anatomical orientation, see the vtk example: https://examples.vtk.org/site/Cxx/VisualizationAlgorithms/AnatomicalOrientation/

import pyvista as pv
from pyvista import examples
human = examples.download_human()
planes = pv.OrthogonalPlanesSource(human.bounds).output
pl = pv.Plotter()
pl.add_mesh(human)
pl.add_mesh(planes, opacity=0.3, show_edges=True)
pl.show()

@user27182 user27182 marked this pull request as draft July 11, 2024 00:51
@pyvista-bot pyvista-bot added the enhancement Changes that enhance the library label Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.24%. Comparing base (766085e) to head (badb734).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6366   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files         142      142           
  Lines       26595    26681   +86     
=======================================
+ Hits        25861    25947   +86     
  Misses        734      734

@user27182 user27182 changed the title Add new OrthoPlanesSource for generating orthonormal planes Add OrthogonalPlanesSource for generating orthogonal planes Jul 11, 2024
@user27182
Copy link
Contributor Author

@pyvista-bot preview

@user27182 user27182 marked this pull request as ready for review July 11, 2024 15:49
@pyvista-bot
Copy link
Contributor

🚀 Deployed on https://669012772f8951136c549c24--meek-duckanoo-d2f5ec.netlify.app

@user27182
Copy link
Contributor Author

@pyvista-bot preview

@pyvista-bot
Copy link
Contributor

🚀 Deployed on https://669068a2767262734b9d6312--meek-duckanoo-d2f5ec.netlify.app

@user27182
Copy link
Contributor Author

pre-commit.ci autofix

@user27182 user27182 mentioned this pull request Jul 17, 2024
Open
@user27182 user27182 closed this Jul 17, 2024
@user27182 user27182 reopened this Jul 17, 2024
@pyvista-bot pyvista-bot added the documentation Anything related to the documentation/website label Jul 17, 2024
tkoyama010
tkoyama010 reviewed Jul 18, 2024
View reviewed changes
@tkoyama010
Copy link
Member

pre-commit.ci autofix

tkoyama010
tkoyama010 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Strictly speaking, we should deploy the document preview in the pyvista repository branch, but the effect we will get is limited. We will not run it here.

@tkoyama010 tkoyama010 enabled auto-merge (squash) July 19, 2024 04:56
@user27182
Copy link
Contributor Author

Looks like we another documentation cache issue, similar to #6393 (comment)
This time the issue is with images removed from the docs in #6389.

@tkoyama010 tkoyama010 merged commit 4446315 into pyvista:main Jul 20, 2024
@user27182 user27182 mentioned this pull request Jul 24, 2024
Merged
@user27182 user27182 mentioned this pull request Mar 2, 2025
Open
@banesullivan banesullivan mentioned this pull request Apr 17, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoyama010 tkoyama010 tkoyama010 approved these changes

Assignees
No one assigned
Labels
documentation Anything related to the documentation/website enhancement Changes that enhance the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@user27182 @pyvista-bot @tkoyama010