-
Notifications
You must be signed in to change notification settings - Fork 591
Add PlanesAssembly
class adding orthogonal planes to a scene
#6379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is awesome! Thanks for working for this :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6379 +/- ##
==========================================
+ Coverage 97.25% 97.27% +0.02%
==========================================
Files 142 142
Lines 26763 26984 +221
==========================================
+ Hits 26029 26250 +221
Misses 734 734 |
The |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Overview
This class uses the
OrthogonalPlanesSource
from #6366 to create a new assembly class.It inherits from
XYZAssembly
and is similar to theAxesAssembly
class with the following main differences:AxesAssembly
usesAxesGeometrySource
for its geometry, whereasPlanesAssembly
usesOrthogonalPlanesSource
AxesAssembly
uses theLabel
class for its labels, whereasPlanesAssembly
uses a customizedvtkAxisActor
Here's a preview of this feature using similar a similar example to the AnatomicalOrientation vtk example. Unlike that example, which uses
vtkVectorText
for the plane labels which remain static and will appear "backwards" if viewed from behind the plane, the labels for this new class instead follow the camera.PlanesAssembly.mov