Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (d9bf85a) to head (52251ee).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #7001   +/-   ##
=======================================
  Coverage   97.50%   97.51%           
=======================================
  Files         144      144           
  Lines       28554    28556    +2     
=======================================
+ Hits        27843    27845    +2     
  Misses        711      711           

🚀 Deployed on https://6766055e44e08b8628228116--pyvista-dev.netlify.app

LGTM. Just a minor suggestion: The variable split is accessed globally from outside the function, which made the code slightly harder to follow. It might be a good idea to modularize the internal functions for better readability. It is another PR anyway.

I'm not sure I follow, extract_values has a keyword argument split, do you mean this is defined elsewhere? Should currently be defined at the root function level:

def extract_values(split):
    ...
    if split: 
        ...

LGTM. Just a minor suggestion: The variable split is accessed globally from outside the function, which made the code slightly harder to follow. It might be a good idea to modularize the internal functions for better readability. It is another PR anyway.

I'm not sure I follow, extract_values has a keyword argument split, do you mean this is defined elsewhere? Should currently be defined at the root function level:

def extract_values(split):
    ...
    if split: 
        ...

I meant my comment in the sense that I was a bit confused because _validate_values_and_ranges does not have split as an argument. But this is a minor issue since, as you say, it is immediately obvious that it is in the extract_values.

Oh I understand now, the variable scope is not local. Yes that can be confusing (and buggy).