Update docker.rst #7814
Open
Update docker.rst #7814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated instructions to "Create your own Docker Container with PyVista"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7814 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 150 150
Lines 32656 32656
Branches 4114 4114
=======================================
Hits 31482 31482
Misses 570 570
Partials 604 604 |
akaszynski
reviewed
Aug 12, 2025
Forgot to cd into directory.
akaszynski
reviewed
Aug 12, 2025
Comment on lines
+46
to
+49
| pip install build | ||
| python -m build --sdist | ||
| IMAGE=my-pyvista-jupyterlab | ||
| docker build -t $IMAGE -f docker/jupyter.Dockerfile . |
There was a problem hiding this comment.
@banesullivan, you made this.
If tit's necessary to build the sdist here? If this is necessary, shouldn't it be in Dockerfile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated instructions to "Create your own Docker Container with PyVista"
Overview
Updating the instructions to build a Docker Container. I found the previous instructions out of date with the repository './docker/README.md'. This should address the fix and mean readthedocs is functional again (not requiring a further dive into the repository)
Details
Previous instruction were failing because no pyvist tarball was being built and couldn't be found, thus the
docker buildfailed.