Improve morphological filters for ImageData #7833
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dedicated dilate() and erode() methods - Support continuous data dilation and erosion - Add open() and close() morphological operations - Deprecate image_dilate_erode() in favor of new methods - Add comprehensive tests for all new methods Resolves #7660
- Fix type annotations in morphological filters (dilate/erode methods) - Add proper type ignores for VTK class compatibility issues - Fix DataSet import to use correct module path in TYPE_CHECKING block - Resolve unreachable code warnings in cells.py - Fix abstract class instantiation in dataset.py - Remove unused type ignore comments - Add proper type annotation for mesh_letters in logo.py
…error Fixed type incompatibility in data_set.py:7872 where scalars array with dynamic dtype (uint8, int_, or float64) was assigned to binary_mask['mask'] which expects float type.
- Remove type: ignore[abstract] from pyvista.Cell() instantiation - Remove type: ignore[unreachable] from numpy dtype checks These were no longer needed after previous type fixes.
for more information, see https://pre-commit.ci
- Fix voxelize_binary_mask dtype issue by preserving original dtype instead of casting to float - Update image_dilate_erode doctest to use the non-deprecated close() method - Both fixes maintain the same functionality while resolving doctest failures
Cast scalars array to float before assignment to binary_mask['mask'] to resolve mypy type incompatibility. The __setitem__ method expects float arrays, but scalars could be uint8, int, or float64 depending on the input values. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
tkoyama010
commented
Aug 23, 2025
tkoyama010
commented
Aug 23, 2025
Wrap deprecated image_dilate_erode method calls with pytest.warns to properly handle expected PyVistaDeprecationWarning in tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7833 +/- ##
=======================================
Coverage 96.40% 96.41%
=======================================
Files 150 150
Lines 32675 32726 +51
Branches 4114 4122 +8
=======================================
+ Hits 31501 31552 +51
Misses 570 570
Partials 604 604 |
- Add tests for progress_bar parameter - Add tests for error conditions when active scalars are cell data - Add tests for custom kernel sizes - Improve overall test coverage for new morphological filter methods
These cached test images are no longer needed after recent improvements to the morphological filter implementation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Deleted obsolete image cache files for dilate_erode filter tests as part of morphological filters improvement. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
user27182
reviewed
Sep 10, 2025
There was a problem hiding this comment.
Haven't reviewed closely yet but it's not clear to me if continous should even be needed as a keyword, as I'm not exactly sure what the difference in output would be for some common use cases, it may be be that the continuous filters do everything the binary ones do, plus more, i.e. perhaps they are more general.
The use of additional examples would help clear this up.
In addition, the current examples have a binary image input and binary output, but the plots use interpolation to color the cells. Instead, visualizing the point data as cell data using something points_to_cells before plotting would help make the plot actually appear binary.
Agreed, would be nice to have some additional examples for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7660