-
Notifications
You must be signed in to change notification settings - Fork 588
Enable parallel testing #7885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable parallel testing #7885
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7885 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 150 150
Lines 32675 32675
Branches 4115 4115
=======================================
Hits 31501 31501
Misses 570 570
Partials 604 604 |
An attempt of using parallel jobs for testing was already proposed in another PR and led to the same conclusion, ie. that downloadable datasets must occur within fixtures to prevent such kind of issues |
That's the second time I've neglected to use that PR as a basis. Seems like there are several changes that are needed to get |
Possible unstable test |
|
Ran cluster local testing on docker and discovered that <9.4 segfaults on
This matches the failures we've had here so far. I'm not seeing any difference in the render window used as it's identical across all versions of VTK on our CI, so there might be another change under the hood that's causing this.
On Linux, we might be able to reliably run parallel testing for VTK >= 9.4 on Linux, and parallel core testing for all. Windows appears rock solid for the past several runs. |
@@ -76,17 +76,19 @@ cov_flags = | |||
html:coverage_{env_name} | |||
|
|||
test_downloads = --test_downloads | |||
disallow_unused_cache = --disallow_unused_cache | |||
disallow_unused_cache = # --disallow_unused_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we waiting for a new pytest-pyvista release? Is this ready otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, just waiting for the next release of pytest-pyvista
.
Enable parallel testing using
tox
(thanks for implementing this @beroda). This is compatible with both our self-hosted and GitHub hosted runners.--disallow_unused_cache
once it's fixed withinpyvista-pytest
Notes:
Documentation upload steps should not run when canceled. GitHub recommends usingResolved in Only upload docs when not cancelled #7890.!cancelled()
instead ofalways()
in Workflows and Actions - always. Using this unblocks canceled documentation builds due to concurrency.