Set VTK_DEFAULT_OPENGL_WINDOW for specific tox jobs #7945
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7945 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 150 150
Lines 32682 32682
Branches 4118 4118
=======================================
Hits 31508 31508
Misses 570 570
Partials 604 604 |
… with CI variable
|
Per #7945 (comment), waiting for #7948 to be closed before continuing this PR. |
|
Let's continue the thread here
@akaszynski what's your feeling about it ? I'm +1 with the idea of specifying the value of |
|
I think there was a previous PR where @akaszynski also had issues with these docstrings. We could probably just skip the doctest for these, clean up the output and not use numpy printoptions. These functions have plenty of test coverage for numerical error / sign differences in the unit tests and don't need the coverage from the docstrings. |
This reverts commit 0d7788e.
| PYTEST_ADDOPTS = --color=yes -v {env:PARALLEL:} | ||
| commands = | ||
| modules: pytest --doctest-modules {env_site_packages_dir}{/}pyvista {posargs} | ||
| modules: pytest --doctest-modules --doctest-continue-on-failure {env_site_packages_dir}{/}pyvista {posargs} |
There was a problem hiding this comment.
Found convenient to use --doctest-continue-on-failure since it enables to see all docstring issues and not only the first one.
| >>> normal # doctest:+SKIP | ||
| pyvista_ndarray([0.0, 0.0, 1.0], dtype=float32) |
There was a problem hiding this comment.
Ran into rounding errors with this. The workaround was to round, but was quite verbose. Alternative would be converting to np.float64
The render window only needs to be set for plotting tests, though it shouldn't matter outside of the plotting jobs. |
Let's open a new PR to explicitly set VTK_DEFAULT_OPENGL_WINDOW for all tests. |
Overview
VTK_DEFAULT_OPENGL_WINDOWenv variable is set on thetoxconfig. It prevents users from changing its value outside of tox.This PR fixes that by setting the env variable specifically when the
CIenv variable is true.Moreover,
VTK_DEFAULT_OPENGL_WINDOWis also explicitely specified fordoctest-modulesjob.