🚀 Deployed on https://68c5862f3f2e3dd5895a6423--pyvista-dev.netlify.app

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (c556a05) to head (4e308fd).

@@           Coverage Diff           @@
##             main    #7951   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         150      150           
  Lines       32682    32684    +2     
  Branches     4118     4118           
=======================================
+ Hits        31508    31510    +2     
  Misses        570      570           
  Partials      604      604           

Why this instead of the cell array to cover all cell types?

Why this instead of the cell array to cover all cell types?

At least in the versions I've tested (9.4 and 9.5.X), polyhedron cells are stored in two separate vtkCellArrays.

• https://vtk.org/doc/nightly/html/classvtkUnstructuredGrid.html#a4c5241068181cb067d046e9a92e58bf6
• https://vtk.org/doc/nightly/html/classvtkUnstructuredGrid.html#a874acf928c41c24dc0e8ee391f2d718f

There's a discussion on why and how this was changed:
https://discourse.vtk.org/t/polyhedral-cells-storing-faces-as-vtkcellarray/5656

Given the failures for earlier versions, we're going to have to include backwards compatibility for this check.

Should we also be checking the cell array is equal for other cell types?

I don't think so. We only included it here to make sure that we're genuinely changing the polyhedrons and not the underlying cell array. It's helpful for this test since VTK has been changing their API and if it's changed again, we can catch it here.

I don't think so. We only included it here to make sure that we're genuinely changing the polyhedrons and not the underlying cell array. It's helpful for this test since VTK has been changing their API and if it's changed again, we can catch it here.

Sorry I wasnt clear. I didn't mean due this test here. I meant to check the cell arrays during the equivalency check? I don't see this currently.

I don't think so. We only included it here to make sure that we're genuinely changing the polyhedrons and not the underlying cell array. It's helpful for this test since VTK has been changing their API and if it's changed again, we can catch it here.

Sorry I wasnt clear. I didn't mean due this test here. I meant to check the cell arrays during the equivalency check? I don't see this currently.

It we don't we should.