Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rework Dockerfile to use separate base Docker image [ch261] #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pzelnip
Copy link
Owner

@pzelnip pzelnip commented Aug 11, 2018

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the master branch.
    • Also please start your branch off our master.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

In the hopes of improving build times (and avoiding npm timeout issues that seem to happen relatively often with Travis), refactored the Dockerfile to use a base image that I build myself. See: https://github.com/pzelnip/codependentcodrbase

The idea is that that base image will have the stuff that almost never changes, and then this repo uses that as a base image and installs the things that change more often.

I may in the future move requirements.txt to that repo & image. It's pretty rare I change requirements (auto updates from pyup aside).

Useful Resources

https://hub.docker.com/r/pzelnip/codependentcodrbase/
https://github.com/pzelnip/codependentcodrbase

@pzelnip pzelnip merged commit 72ebdd7 into master Aug 11, 2018
@pzelnip pzelnip deleted the codependentcodr/ch261/refactor-dockerfile-to-build-a-new-base-image branch August 11, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant