Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add vscode logo image #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2021
Merged

Add vscode logo image #210

merged 2 commits into from
Apr 3, 2021

Conversation

pzelnip
Copy link
Owner

@pzelnip pzelnip commented Apr 3, 2021

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your mainline!
  • Make sure you are making a pull request against the mainline branch.
    • Also please start your branch off our mainline.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

Useful Resources

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 3, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.08 ⭐ 1.08 ⭐ 0.00
Method Length 50.77 ⭐ 50.77 ⭐ 0.00
Working memory 9.56 🙂 9.56 🙂 0.00
Quality 69.60% 🙂 69.60% 🙂 0.00%
Other metrics Before After Change
Lines 630 630 0
Changed files Quality Before Quality After Quality Change
pelicanconf.py 59.82% 🙂 59.82% 🙂 0.00%
publishconf.py 93.69% ⭐ 93.69% ⭐ 0.00%
s3prcing.py 61.53% 🙂 61.53% 🙂 0.00%
update_cache_control.py 75.23% ⭐ 75.23% ⭐ 0.00%
theme/Flex/transifex.py 74.89% 🙂 74.89% 🙂 0.00%
theme/Flex/docs/pelicanconf.py 66.77% 🙂 66.77% 🙂 0.00%
theme/Flex/docs/publishconf.py 64.28% 🙂 64.28% 🙂 0.00%
theme/Flex/docs/tasks.py 79.35% ⭐ 79.35% ⭐ 0.00%
theme/Flex/pygments/generate.py 79.19% ⭐ 79.19% ⭐ 0.00%
theme/Flex/tests/pelicanconf.py 58.67% 🙂 58.67% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
s3prcing.py main 0 ⭐ 135 😞 14 😞 57.97% 🙂 Try splitting into smaller methods. Extract out complex expressions
update_cache_control.py update_file 3 ⭐ 85 🙂 15 😞 60.25% 🙂 Extract out complex expressions
theme/Flex/transifex.py download 1 ⭐ 103 🙂 12 😞 63.96% 🙂 Extract out complex expressions
theme/Flex/transifex.py list_languages 5 ⭐ 76 🙂 11 😞 65.59% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@pzelnip pzelnip merged commit 474394a into mainline Apr 3, 2021
@pzelnip pzelnip deleted the vscode-tip-of-the-day branch April 3, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pzelnip