fix: add regression test for optional qdrant-store metadata#138
Open
itsjawreal wants to merge 1 commit into
Open
fix: add regression test for optional qdrant-store metadata#138itsjawreal wants to merge 1 commit into
itsjawreal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a focused regression test for
qdrant-storeso storing content without ametadataargument stays supported. The test drives the server through a real FastMCP client and verifies the connector still receivesmetadata=None.Why it matters
src/mcp_server_qdrant/mcp_server.pyalready documents that themetadataparameter shape is client-sensitive, especially for MCP clients such as Cursor. Without coverage, a refactor can silently makemetadatarequired or stop passingNone, breaking normal store calls from clients that omit the field.Testing
Added
tests/test_mcp_server.pywith an async regression test that instantiatesQdrantMCPServeragainst a mocked connector and callsqdrant-storethroughfastmcp.Client. The assertion checks both the returned confirmation message and that the storedEntrystill carriesmetadata=None.