Fix memory exhaustion problem caused by the logger #1161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
Hi!
This PR is a proposed fix for a memory exhaustion problem I found while creating multiple
Qiling
objects. Here's a snippet of code that triggers the bug:This snippet will eventually saturate the RAM and the SWAP because the
Qiling
objects are not properly garbage collected.The problem here is that when the
Qiling
object gets out of scope the Python root log manager still holds a reference to it. This is caused by the fact that the logger formatter needs to have a reference to it so it can retrieve the current thread information while formatting the log message.Substituting the reference with a
weak reference
solves the problem since now when the object goes out of scope only weak references are pointing to it and therefore the garbage collector is allowed to free the space.