Fix KaTeX rendering in crossref previews #12288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in quarto-dev#12259, Tippy.js popups on crossrefs failed if the previewed entity contained KaTeX math elements. This seems to be due to double rendering where the `data` attribute is unset on the second pass. Just skipping the invocation of the KaTeX renderer in these instances solves the issue.
|
Thank you for the PR! We very much appreciate it. @cderv do you think it's feasible to create a playwright test that would verify that this behavior is fixed? The change makes sense but it would be great if we added coverage here. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12259.
As described in #12259, Tippy.js popups on crossrefs fails if the previewed entity contains KaTeX math elements. This seems to be due to double rendering where the
dataattribute is unset on the second pass. Just skipping the invocation of the KaTeX renderer in these instances solves the issue.Checklist
I have (if applicable):
... I feel that most of the list does not quite apply for this minor change. But I can look into Contributor Agreement and changelog tomorrow if desired.