Parse child of mispelled await expression as if it was inside async #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we detect that `await` is followed by an arrow function early inside `is_identifier` function we can avoid treating `await` as an identifier and correctly identify that the intention of the user was to use `async`.
We detect that the intention of the user was to use `async` and parse its child as if so.
|
Not sure why dnf doesn't like, welp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now quick-lint-js for the following code
correctly detects the intention of user to use
asyncinstead ofawaitbut throw another error forawaitexpression inside the arrow function. This PR fix this by parsing the subsequent expression as aasyncexpression if we detect such intention.This PR should also fix #278.