Tentative move to Java 25 #2004
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This 'works', but is likely to require 1 big change and 2 small ones. The big change is that removing '--bind-services' is probably stripping back the JRE too much, and we'll need to add in more modules or switch to a JDK other than Temurin so that we --bind-services can be reinstated. The small changes: - Use Kotlin 2.3 when available - Use 2.0.0 for org.beryx.runtime when available The license plugin should also be updated whenever possible, since it currently means we can only use jpackage if the build isn't parallelized.
|
Reminder: The content under the 'Annotations' tab rescales badly with this PR (presumably due to a JavaFX change). |
This was introduced in JavaFX 25, possibly with other `Region`-related changes that introduced a few regressions (or possibly because our original approach was flawed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 'works', but is likely to require 1 big change and 2 small ones.
The big change is that removing
--bind-servicesis almost certainly stripping back the JRE too much, and we'll need to add in more modules or switch to a JDK other than Temurin so that--bind-servicescan be reinstated.The small changes:
The license plugin should also be updated whenever possible, since it currently means we can only use jpackage if the build isn't parallelized.