Posterize review comments updates #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-abishek
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds explanatory comments to the posterize function implementation to clarify the purpose of validation checks and mathematical operations used in image posterization.
- Adds inline comments explaining the 8-bit validation check for posterization level bits
- Adds comments describing mask and factor generation for posterization operations
- Improves code documentation for better maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/tensor/rppt_tensor_effects_augmentations.cpp | Adds inline comment explaining 8-bit validation for posterize level bits in both host and GPU functions |
| src/modules/tensor/cpu/kernel/posterize.cpp | Adds comments explaining mask and factor generation for posterization operations across different data types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Rpp32u vectorIncrement = 24; | ||
| Rpp32u vectorIncrementPerChannel = 8; | ||
|
|
||
| // Mask generated based on the number of bits to represent the image for image posterization |
There was a problem hiding this comment.
The comment incorrectly describes this as a 'mask' when the code actually creates a mask value stored in posterizeBitsMask. Consider clarifying: '// Mask value generated based on the number of bits to represent the image for image posterization'
Suggested change
| // Mask generated based on the number of bits to represent the image for image posterization | |
| // Mask value generated based on the number of bits to represent the image for image posterization |
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
* Initial version - gaussian Filter * Add Implementation of 5x5 7x7 and 9x9 kernel sizes * fix QA issues for 3x3 kernel size * Fix QA mismatches * Add generic kernel code cleanup Add golden output * Add Doxygen comments * Add golden 9x9 golden output and remove unnecessary code * Resolve Review comments * Resolve review comments * Resolve Review comments * resolve review comments * minor change * remove the common code * Update CHANGELOG.md --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.