Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remotes without package names are now unconditionally installed again #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Remotes without package names are now unconditionally installed again #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc683bf
Remotes without package names are now unconditionally installed again
jakubkovac Aug 19, 2020
bbb71dc
Add note to news
jimhester Mar 30, 2021
e214553
Merge branch 'master' into master
jimhester Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# remotes (development version)

* remotes without package names are now unconditionally installed (#532, @jakubkovac)

* It is now possible to specify a custom host for dependencies listed in the `DESCRIPTION` file with `Remotes: <type>[@host]::<username>/<repo>[@ref]`. The `ref` now supports `/` in it for `GitLab` repositories as it did for `GitHub`repositories. (@dagola, #448)

* Internal `package2remote()` function now supports local remotes created by pak.

* `install_*()` functions will no longer fail by default if there warnings from `install.packages()`. Concretely the default value of `R_REMOTES_NO_ERRORS_FROM_WARNINGS` has changed to `true` from the previous value of `false`. (#403)
Expand Down
2 changes: 1 addition & 1 deletion R/deps.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ dev_package_deps <- function(pkgdir = ".", dependencies = NA,

res <- do.call(rbind, c(list(res), lapply(get_extra_deps(pkg, dependencies), extra_deps, pkg = pkg), stringsAsFactors = FALSE))

res[!duplicated(res$package, fromLast = TRUE), ]
res[is.na(res$package) | !duplicated(res$package, fromLast = TRUE), ]
}

combine_remote_deps <- function(cran_deps, remote_deps) {
Expand Down
10 changes: 10 additions & 0 deletions tests/testthat/test-deps.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,3 +548,13 @@ test_that("dev_package_deps can retrieve custom fields", {
expect_true(any(is_covr))
expect_is(res$remote[is_covr][[1]], "cran_remote")
})

test_that("dev_package_deps works with url remotes", {
skip_on_cran()
skip_if_offline()

res <- dev_package_deps(test_path("urlremotes"), dependencies = TRUE)

expect_equal(sum(is.na(res$package)), 2)

})
15 changes: 15 additions & 0 deletions tests/testthat/urlremotes/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Package: noremotes
Title: Tools to make developing R code easier
License: MIT
Description: Package description.
Author: Bugs Bunny
Maintainer: Bugs Bunny <[email protected]>
Version: 1.0.0
Suggests: testthat
Imports:
example,
dtplyr
Remotes:
url::https://www.example.com/,
url::https://github.com/tidyverse/dtplyr