Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix regex that broke git@xxx in install-git #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2021
Merged

Fix regex that broke git@xxx in install-git #630

merged 2 commits into from
Jun 23, 2021

Conversation

niheaven
Copy link
Contributor

The regex that fixed in #603 breaks git@xxx by accident 😭

It just try to handle @xxx as ref, change it from (?:(?<url>[^@]*))(?:@(?<ref>.*))?) to (?<url>(?:git@)?[^@]*)(?:@(?<ref>.*))? will fix the problem.

After fix:

remotes:::git_remote("[email protected]:v3/dataapi-rclient", git = "external")
#> $url
#> [1] "[email protected]:v3/dataapi-rclient"
#> 
#> $subdir
#> NULL
#> 
#> $ref
#> NULL
#> 
#> attr(,"class")
#> [1] "xgit_remote" "remote"
remotes:::git_remote("[email protected]:group/package.git")
#> $url
#> [1] "[email protected]:group/package.git"
#> 
#> $subdir
#> NULL
#> 
#> $ref
#> NULL
#> 
#> $credentials
#> NULL
#> 
#> attr(,"class")
#> [1] "git2r_remote" "remote"
remotes:::git_remote("https://gitlab.company.com/group/package.git@master") 
#> $url
#> [1] "https://gitlab.company.com/group/package.git"
#> 
#> $subdir
#> NULL
#> 
#> $ref
#> [1] "master"
#> 
#> $credentials
#> NULL
#> 
#> attr(,"class")
#> [1] "git2r_remote" "remote"
remotes:::git_remote("[email protected]:group/package.git@v3")
#> $url
#> [1] "[email protected]:group/package.git"
#> 
#> $subdir
#> NULL
#> 
#> $ref
#> [1] "v3"
#> 
#> $credentials
#> NULL
#> 
#> attr(,"class")
#> [1] "git2r_remote" "remote"

@jimhester jimhester merged commit 920e4a3 into r-lib:master Jun 23, 2021
@jimhester
Copy link
Member

Thanks!

@niheaven niheaven deleted the fix-git_remote_regex branch June 27, 2021 10:41
@hokkwan hokkwan mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git_remote fails to parse gitlab urls with git protocol install_git() fails to install package from AzureDevOps with command status 128
2 participants
@niheaven @jimhester