Upgrade RabbitMQ Prometheus sample docker images #14953
Merged
michaelklishin merged 3 commits intoNov 14, 2025
Merged
Conversation
michaelklishin
requested changes
Nov 14, 2025
michaelklishin
left a comment
Collaborator
There was a problem hiding this comment.
Thank you. I have one nitpick.
This is a non-functional change so I don't think you need to sign our CLA but if you could do that, our team would appreciate it.
| rmq0: &rabbitmq | ||
| # https://hub.docker.com/r/pivotalrabbitmq/rabbitmq/tags | ||
| image: pivotalrabbitmq/rabbitmq:master-otp-max | ||
| image: rabbitmq:4.0-management |
Collaborator
There was a problem hiding this comment.
Please use 4-management instead of 4.0 specifically.
Contributor
Author
|
Hey @michaelklishin thanks for the review. I am from AWS, I think I am already covered for the CLA. |
Collaborator
|
@kenliao94 ah, OK. Then you are :) |
michaelklishin
approved these changes
Nov 14, 2025
12 tasks
michaelklishin
added a commit
that referenced
this pull request
Nov 14, 2025
Upgrade RabbitMQ Prometheus sample docker images (backport #14953)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The RabbitMQ Prometheus demo is outdated with Dockers images that are unable to start. It also references deprecated
docker-composeCLI command.I upgraded the Docker images to use RabbitMQ 4 and a new version of
cadvisorand changed the Makefile to usedocker composeinstead ofdocker-composeI also updated the doc at rabbitmq/rabbitmq-website#2393
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.