Friendly TLS mismatch errors#16342
Merged
Merged
Conversation
When someone mistakenly tried to connect without TLS to a TLS-enabled listener or wit TLS to a non-TLS listener, we logged all kinds of confusing errors (bad headers, unexpected messages, frame too large, etc). Now we just log a user-friendly message
lhoguin
approved these changes
May 7, 2026
Contributor
lhoguin
left a comment
There was a problem hiding this comment.
LGTM. I was wondering about log_level vs log_alert and log_alert is deprecated in favor of log_level so all is good.
mkuratczyk
added a commit
that referenced
this pull request
May 7, 2026
* run-tls-broker enables TLS for MQTT, STOMP and STREAM * Graceful handling of TLS/non-TLS mismatch When someone mistakenly tried to connect without TLS to a TLS-enabled listener or wit TLS to a non-TLS listener, we logged all kinds of confusing errors (bad headers, unexpected messages, frame too large, etc). Now we just log a user-friendly message (cherry picked from commit 678fec2) Co-authored-by: Michal Kuratczyk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone mistakenly tried to connect without TLS
to a TLS-enabled listener or with TLS to a non-TLS
listener, we logged all kinds of confusing errors
(bad headers, unexpected messages, frame too large, etc).
Now we just log a user-friendly message