-
Notifications
You must be signed in to change notification settings - Fork 48
OSPC-908 Standardize subdirectory structure for services in base-kustomize #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gaurav-t
wants to merge
1
commit into
rackerlabs:main
Choose a base branch
from
Gaurav-t:ospc-908
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome, new contributor!
|
Welcome, new contributor!
|
cloudnull
approved these changes
May 7, 2025
LGTM but @Gaurav-t you will need to address the linting issues found here https://github.com/rackerlabs/genestack/actions/runs/14876361058/job/41774314739?pr=970 |
yamllint failing. Once this is corrected we can get this merged! |
Welcome, new contributor!
|
…omize It updates the directory structure for remaining base-kustomize services to follow standardized pattern where each service contains a subdirectory named - base. Also, changes the docs, workflows and references to reflect the new structure.
Welcome, new contributor!
|
@cloudnull @rackerchris Linting issues resolved. All checks appear passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It updates the directory structure for remaining base-kustomize services
to follow standardized pattern where each service contains a subdirectory
named - base. Also, changes the docs, workflows and references to reflect
the new structure.