-
Notifications
You must be signed in to change notification settings - Fork 7
feat(openstack): share service acct credentials via ESO #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e67f52
to
431b431
Compare
431b431
to
a9ba646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this makes sense to me. The docs may also use a section explaining why we cannot immediately remove the secret-openstack.yaml
. I have also left a few comments inline.
The commit I just added makes it so we can get rid of part of it. |
d5a7979
to
6657a7d
Compare
Ah I should have kept the changes separate but I squashed them all in @skrobul. Sorry. But I think I've now addressed all your reviews. |
6657a7d
to
c35ac8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
2718cbe
to
e49857c
Compare
Utilize the External Secrets Operator to define the OpenStack service account credentials that OpenStack Helm needs to work with Keystone service accounts for the various OpenStack services. This allows one cluster to run Keystone and another to run the OpenStack services and to utilize the ESO operator to keep the credentials in sync between the two. Co-authored-by: Marek Skrobacki <[email protected]>
The change to mount these has not landed in all upstream charts and we've also not updated to the charts that have this change across the board. So for now include it in all of our configs until this change can make its way upstream.
fba2060
to
ba214e0
Compare
…scripts The --config-file flag is hardcoded in a number of scripts which results in preference to that file over the directories which is not the behavior we want since we want to override. However since the OpenStack Helm charts provide no way to change this behavior we need to replace the entire configmap-bin. This one is taken from two environments which were identical and then had the --config-dir flag added so that it continues to work.
ba214e0
to
ad14140
Compare
Utilize the External Secrets Operator to define the OpenStack service account credentials that OpenStack Helm needs to work with Keystone service accounts for the various OpenStack services. This allows one cluster to run Keystone and another to run the OpenStack services and to utilize the ESO operator to keep the credentials in sync between the two.