fix(ironic): includes fixes that were missed from #1235 #1241
+821
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been part of ad14140. It's commit message is below. The --config-file flag is hardcoded in a number of scripts which results in preference to that file over the directories which is not the behavior we want since we want to override. However since the OpenStack Helm charts provide no way to change this behavior we need to replace the entire configmap-bin. This one is taken from two environments which were identical and then had the --config-dir flag added so that it continues to work.
This was missed from c589b4. It's commit message is below. The change to mount these has not landed in all upstream charts and we've also not updated to the charts that have this change across the board. So for now include it in all of our configs until this change can make its way upstream.
skrobul
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should have happened to ironic as part of #1235 and were missed. These are those fixes.