chore: adding BigtableVeneerApi to expose veneer implementation #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
924972c to
cf8b246
Compare
pmakani
previously approved these changes
Apr 3, 2020
athakor
previously approved these changes
Apr 3, 2020
dmitry-fa
reviewed
Apr 3, 2020
...ase/src/test/java/com/google/cloud/bigtable/hbase/wrappers/veneer/TestBigtableVeneerApi.java
Show resolved
Hide resolved
...ase/src/test/java/com/google/cloud/bigtable/hbase/wrappers/veneer/TestBigtableVeneerApi.java
Show resolved
Hide resolved
| ReadRowsRequest request = fakeDataService.popLastRequest(); | ||
| assertEquals(ROW_KEY, request.getRows().getRowKeys(0).toStringUtf8()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks a lot for the review!!
I had intentionally left the test case for close() because we don't have a way to verify with mock Server.
5170a70 to
adc82e7
Compare
The base branch was changed.
This PR adds BigtableVeneerApi, which exposes veneer implementation of Data and Admin clients.
f748569 to
d98c42d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BigtableVeneerApi, which exposes veneer implementation of Data and Admin clients.