chore: more utility clean up from bigtable-hbase module #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakani
previously approved these changes
Apr 16, 2020
athakor
reviewed
Apr 16, 2020
...ore-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/util/ThreadUtil.java
Outdated
Show resolved
Hide resolved
athakor
previously approved these changes
Apr 16, 2020
dmitry-fa
reviewed
Apr 16, 2020
...ore-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/util/ThreadUtil.java
Show resolved
Hide resolved
This PR removes references of `BigtableInstanceName` and `ThreadUtil`, which resides in bigtable-core module. ThreadUtil is copied over to `bigtable-hbase`.
4242085 to
5912923
Compare
dmitry-fa
previously approved these changes
Apr 16, 2020
| * | ||
| * <p>This class copies code that originates in {@link | ||
| * io.grpc.internal.GrpcUtil#getThreadFactory(String, boolean)}. | ||
| * |
There was a problem hiding this comment.
Are you sure that this note should be here? (I don't know, just asking)
There was a problem hiding this comment.
Yes, It still holds true for our utility. So it's best to keep track of it.
- used GrpcUtil#getThreadFactory for creating thread factory. - moved `ThreadUtil.java` under `src/test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes references of
BigtableInstanceNameandThreadUtil, which resides inbigtable-coremodule. ThreadUtil is copied over tobigtable-hbasefrom the core module.