Fixed typo in deprecation Rails 2.3.9 deprecation warning#7
Closed
sferik wants to merge 1 commit intorails:2-3-stablefrom
sferik:d462ca226b4b61c8ce90b9541b686c121ac725a1
Closed
Fixed typo in deprecation Rails 2.3.9 deprecation warning#7sferik wants to merge 1 commit intorails:2-3-stablefrom sferik:d462ca226b4b61c8ce90b9541b686c121ac725a1
sferik wants to merge 1 commit intorails:2-3-stablefrom
sferik:d462ca226b4b61c8ce90b9541b686c121ac725a1
Conversation
Object#returning should be Kernel#returning
tenderlove
added a commit
that referenced
this pull request
Dec 21, 2011
tenderlove
added a commit
that referenced
this pull request
Dec 21, 2011
Karunakar
pushed a commit
to Karunakar/rails-1
that referenced
this pull request
Dec 23, 2011
rafaelfranca
pushed a commit
to rafaelfranca/omg-rails
that referenced
this pull request
Jul 31, 2017
Correct config path in error message
yahonda
pushed a commit
to yahonda/rails
that referenced
this pull request
Mar 29, 2022
…pport_rails70z_1_to_main Skip test_with_lock_configures_transaction until savepoint supported
yahonda
pushed a commit
to yahonda/rails
that referenced
this pull request
Mar 30, 2022
…pport_rails70z_1_to_main Skip test_with_lock_configures_transaction until savepoint supported
yahonda
pushed a commit
to yahonda/rails
that referenced
this pull request
Mar 30, 2022
Merge pull request rails#7 from yahonda/follow_up_rails_changes_to_support…
jeremy
pushed a commit
to jeremy/rails
that referenced
this pull request
Dec 5, 2025
ActiveStorage uses the plural `transformations` for a single hash of transformation options (e.g., `{ resize_to_limit: [100, 100] }`).
To differentiate between a single transformation hash and an array of transformation hashes, this commit introduces `transformations_array` for arrays of transformations, while retaining transformations for individual hashes.
jeremy
added a commit
that referenced
this pull request
Dec 5, 2025
* Active storage immediate variants (#6) * This commit introduces variant generation strategies for Active Storage, providing more flexible control over when variants are created. - **:lazily** - variants created dynamically when requested (default) - **:later** - variants created in background after attachment - **:immediately** - variants created simultaneously with attachment ```ruby has_one_attached :avatar_with_lazy_variants do |attachable| attachable.variant :lazy_thumb, resize_to_limit: [3, 3], process: :lazy attachable.variant :default_thumb, resize_to_limit: [4, 4] end has_one_attached :avatar_with_later_variants do |attachable| attachable.variant :later_thumb, resize_to_limit: [2, 2], process: :later end has_one_attached :avatar_with_immediate_variants do |attachable| attachable.variant :immediate_thumb, resize_to_limit: [1, 1], process: :immediately end ``` * Active Storage: make Variant#processed? and VariantWithRecord#processed? public Apps can now check whether variants have been generated. Useful for precise control of variant usage or generation. Co-authored-by: Tom Rossi <[email protected]> * Deprecate `preprocessed: true` in favor of `process: :later` For removal in Rails 9.0. Co-authored-by: Tom Rossi <[email protected]> * Document immediate variants: guide and changelog Co-authored-by: Tom Rossi <[email protected]> * Making ActiveStorage::Preview#processed? a public method Removing space * Use consistent naming for transformations parameter (#7) ActiveStorage uses the plural `transformations` for a single hash of transformation options (e.g., `{ resize_to_limit: [100, 100] }`). To differentiate between a single transformation hash and an array of transformation hashes, this commit introduces `transformations_array` for arrays of transformations, while retaining transformations for individual hashes. * Fixing changelog * Rename transformations_array to variants Aligns with `CreateVariantsJob` naming and `ActiveStorage` terminology where variants represent the result of transformations applied to the original blob. Fixing create_preview_image --------- Co-authored-by: Jeremy Daer <[email protected]> Co-authored-by: Tom Rossi <[email protected]>
drymar
pushed a commit
to drymar/rails
that referenced
this pull request
Jan 5, 2026
* Active storage immediate variants (rails#6) * This commit introduces variant generation strategies for Active Storage, providing more flexible control over when variants are created. - **:lazily** - variants created dynamically when requested (default) - **:later** - variants created in background after attachment - **:immediately** - variants created simultaneously with attachment ```ruby has_one_attached :avatar_with_lazy_variants do |attachable| attachable.variant :lazy_thumb, resize_to_limit: [3, 3], process: :lazy attachable.variant :default_thumb, resize_to_limit: [4, 4] end has_one_attached :avatar_with_later_variants do |attachable| attachable.variant :later_thumb, resize_to_limit: [2, 2], process: :later end has_one_attached :avatar_with_immediate_variants do |attachable| attachable.variant :immediate_thumb, resize_to_limit: [1, 1], process: :immediately end ``` * Active Storage: make Variant#processed? and VariantWithRecord#processed? public Apps can now check whether variants have been generated. Useful for precise control of variant usage or generation. Co-authored-by: Tom Rossi <[email protected]> * Deprecate `preprocessed: true` in favor of `process: :later` For removal in Rails 9.0. Co-authored-by: Tom Rossi <[email protected]> * Document immediate variants: guide and changelog Co-authored-by: Tom Rossi <[email protected]> * Making ActiveStorage::Preview#processed? a public method Removing space * Use consistent naming for transformations parameter (rails#7) ActiveStorage uses the plural `transformations` for a single hash of transformation options (e.g., `{ resize_to_limit: [100, 100] }`). To differentiate between a single transformation hash and an array of transformation hashes, this commit introduces `transformations_array` for arrays of transformations, while retaining transformations for individual hashes. * Fixing changelog * Rename transformations_array to variants Aligns with `CreateVariantsJob` naming and `ActiveStorage` terminology where variants represent the result of transformations applied to the original blob. Fixing create_preview_image --------- Co-authored-by: Jeremy Daer <[email protected]> Co-authored-by: Tom Rossi <[email protected]>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this conversation with Jeremy:
http://twitter.com/sferik/status/23933365677
http://twitter.com/bitsweat/status/23936636728