fix: show uuid on wallet diagnostic #4675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APP-476 wallet diagnostic sheet missing uuid
we moved the ID off of keychain and into mmkv and missed this instance just need to change how we load it |
salman-rb
approved these changes
Feb 28, 2023
estrattonbailey
approved these changes
Feb 28, 2023
estrattonbailey
added a commit
that referenced
this pull request
Mar 1, 2023
…atio-as-buy-button * origin/develop: Update OP rewards copy (#4680) feat: add isAuthenticated util (#4669) chore: use token colors from the BE (#4674) bundle: optimize images (#4678) fix uuid (#4675) fix if statement if nonce = 0 (#4668) bump to 1.8.13 (#4670) [WCv2] fix: wallet/network spacing (#4655)
estrattonbailey
added a commit
that referenced
this pull request
Mar 1, 2023
…-qa-bugs * origin/develop: Update OP rewards copy (#4680) feat: add isAuthenticated util (#4669) chore: use token colors from the BE (#4674) bundle: optimize images (#4678) fix uuid (#4675) fix if statement if nonce = 0 (#4668) bump to 1.8.13 (#4670) [WCv2] fix: wallet/network spacing (#4655) pooly (#4664) APP-464 android only tapping on buy ethereum (#4661) fix: provider card button (#4659) Move SettingsSheet to its own directory in screens (#4650) Add logic to log user out properly when trying to restore backups while having no wallets (#4653) Remove unused codepath for L2 chain assets check in SendSheet (#4652) turn on l2 txs (#4660) Optimize usePersistentDominantColorFromImage hook (#4644) ledger: import flow (#4583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-476
What changed (plus any additional context for devs)
missed when we updated analytics
Screen recordings / screenshots
https://cloud.skylarbarrera.com/Screen-Shot-2023-02-27-18-12-03.59.png
What to test