Provide a way to specify custom HTML renderers, plus fix a buglet #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a very hardcoded config with Template::Mustache in mind was used. We preserve this as a backward-compatible default, but introduce a new role `Pod::To::HTML::Renderer` which provides a simplest working API for a custom page renderer. This is still not completely flexible with regard to the rendering context passed, but for now it allows downstream users to provide good enough custom page renderers.
Author
|
Added a test as well. |
JJ
approved these changes
Mar 29, 2021
JJ
left a comment
There was a problem hiding this comment.
Essentially OK, maybe you'd want to clarify a few things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
As for testing: the tests passing is already a sign it is ok, giving I am using Cro::WebApp it seems just fine enough. I am pretty reluctant to make Cro::WebApp a dependency just to make a test for it, maybe a simple stub would be a better idea.