Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix some code and tests #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raman325 merged 1 commit into from
Jun 15, 2024
Merged

Fix some code and tests #248

raman325 merged 1 commit into from
Jun 15, 2024

Conversation

@raman325
Copy link
Owner

@raman325 raman325 commented Jun 15, 2024 •
edited
Loading

Proposed change

Simplifies the check for whether or not a PIN should be active. Might be a fix for #101

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@github-actions github-actions bot added bug Something isn't working code-quality Pull requests that improve code quality python Pull requests that update Python code labels Jun 15, 2024
@codecov
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (372edbe) to head (f1bd7fd).
Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   90.10%   90.25%   +0.15%     
==========================================
  Files          20       20              
  Lines        1273     1232      -41     
==========================================
- Hits         1147     1112      -35     
+ Misses        126      120       -6
Files Coverage Δ
custom_components/lock_code_manager/__init__.py 97.01% <100.00%> (+0.01%) ⬆️
...stom_components/lock_code_manager/binary_sensor.py 94.11% <100.00%> (+0.78%) ⬆️
custom_components/lock_code_manager/entity.py 99.13% <100.00%> (+1.91%) ⬆️

... and 1 file with indirect coverage changes

@raman325 raman325 merged commit f77159f into main Jun 15, 2024
@raman325 raman325 deleted the fix branch November 5, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working code-quality Pull requests that improve code quality python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raman325